Skip to content

mgmt, upgrade resources/subscriptions#34776

Merged
weidongxu-microsoft merged 8 commits into
Azure:mainfrom
weidongxu-microsoft:mgmt_upgrade-resources
May 5, 2023
Merged

mgmt, upgrade resources/subscriptions#34776
weidongxu-microsoft merged 8 commits into
Azure:mainfrom
weidongxu-microsoft:mgmt_upgrade-resources

Conversation

@weidongxu-microsoft

@weidongxu-microsoft weidongxu-microsoft commented May 4, 2023 •
edited
Loading

Copy link
Copy Markdown
Member
  • upgrade resources as well
  • locally reverted the change on SubscriptionIdParameter, so that it still be x-ms-parameter-location=method <-- pending discussion with service on this

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@azure-sdk

azure-sdk commented May 4, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-resourcemanager-resources

@weidongxu-microsoft
weidongxu-microsoft marked this pull request as ready for review May 4, 2023 11:03
@weidongxu-microsoft weidongxu-microsoft self-assigned this May 4, 2023
@weidongxu-microsoft weidongxu-microsoft added the Mgmt This issue is related to a management-plane library. label May 4, 2023
haolingdong-msft
haolingdong-msft approved these changes May 5, 2023
View reviewed changes

@haolingdong-msft haolingdong-msft left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM.
locally reverted the change on SubscriptionIdParameter, so that it still be x-ms-parameter-location=method <-- pending discussion with service on this -> This seems a big breaking changes, have we confirmed with service team already?

@weidongxu-microsoft

weidongxu-microsoft commented May 5, 2023

Copy link
Copy Markdown
Member Author

Overall LGTM. locally reverted the change on SubscriptionIdParameter, so that it still be x-ms-parameter-location=method <-- pending discussion with service on this -> This seems a big breaking changes, have we confirmed with service team already?

Synced in internal mgmt release group. We probably don't want it, as well as JS and Python. In progress on checking with service.

Last resort would be directive. But it would be complex and I don't want to add now (unless service don't want to change).

@weidongxu-microsoft
weidongxu-microsoft merged commit 637808f into Azure:main May 5, 2023
@weidongxu-microsoft
weidongxu-microsoft deleted the mgmt_upgrade-resources branch May 5, 2023 02:47
jairmyree pushed a commit to jairmyree/azure-sdk-for-java that referenced this pull request May 15, 2023
@weidongxu-microsoft @jairmyree
mgmt, upgrade resources/subscriptions (Azure#34776)
7344b98
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@haolingdong-msft haolingdong-msft haolingdong-msft approved these changes
@XiaofeiCao XiaofeiCao Awaiting requested review from XiaofeiCao XiaofeiCao is a code owner
@ArthurMa1978 ArthurMa1978 Awaiting requested review from ArthurMa1978 ArthurMa1978 is a code owner

Assignees

@weidongxu-microsoft weidongxu-microsoft

Labels

Mgmt This issue is related to a management-plane library.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@weidongxu-microsoft @azure-sdk @haolingdong-msft